vtlim commented on code in PR #12917:
URL: https://github.com/apache/druid/pull/12917#discussion_r949585351
##########
website/redirects.json:
##########
@@ -171,11 +169,11 @@
{"source": "ingestion/overview.html", "target": "index.html"}
{"source": "ingestion/realtime-ingestion.html", "target": "index.html"}
{"source": "ingestion/reports.html", "target": "tasks.html#reports"}
-{"source": "ingestion/schema-changes.html", "target":
"data-management.html#schema-changes"}
+{"source": "ingestion/schema-changes.html", "target":
"faq.html#how-can-i-reindex-existing-data-in-druid-with-schema-changes"}
Review Comment:
I think the target should be
`design/segments.html#segments-with-different-schemas`.
The source of `schema-changes.html` was probably some version of
https://apache.googlesource.com/druid/+/refs/heads/0.13.0-incubating/docs/content/ingestion/schema-changes.md.
The same content is in
https://github.com/apache/druid/blob/master/docs/design/segments.md
##########
docs/querying/timeseriesquery.md:
##########
@@ -78,6 +78,7 @@ There are 7 main parts to a timeseries query:
|intervals|A JSON Object representing ISO-8601 Intervals. This defines the
time ranges to run the query over.|yes|
|granularity|Defines the granularity to bucket query results. See
[Granularities](../querying/granularities.md)|yes|
|filter|See [Filters](../querying/filters.md)|no|
+|virtualColumns|Define any [virtual columns](./virtual-columns.md) to be
available to referenced as inputs to `aggregations` or `postAggregations`.| no
(default none)|
Review Comment:
```suggestion
|virtualColumns|A JSON list of [virtual columns](./virtual-columns.md). You
can reference the virtual columns in `aggregations` or `postAggregations`.| no
(default none)|
```
##########
docs/querying/topnquery.md:
##########
@@ -103,6 +103,7 @@ There are 11 parts to a topN query.
|intervals|A JSON Object representing ISO-8601 Intervals. This defines the
time ranges to run the query over.|yes|
|granularity|Defines the granularity to bucket query results. See
[Granularities](../querying/granularities.md)|yes|
|filter|See [Filters](../querying/filters.md)|no|
+|virtualColumns|Define any [virtual columns](./virtual-columns.md) to be
available to use as the grouping `dimension` or referenced as inputs to
`aggregations` or `postAggregations`.| no (default none)|
Review Comment:
```suggestion
|virtualColumns|A JSON list of [virtual columns](./virtual-columns.md). You
can reference a virtual column as the grouping `dimension` or as an input in
`aggregations` or `postAggregations`.| no (default none)|
```
##########
docs/querying/searchquery.md:
##########
@@ -62,6 +62,7 @@ There are several main parts to a search query:
|limit| Defines the maximum number per Historical process (parsed as int) of
search results to return. |no (default to 1000)|
|intervals|A JSON Object representing ISO-8601 Intervals. This defines the
time ranges to run the query over.|yes|
|searchDimensions|The dimensions to run the search over. Excluding this means
the search is run over all dimensions.|no|
+|virtualColumns|Define any [virtual columns](./virtual-columns.md) to be
available to use as `searchDimensions`.| no (default none)|
Review Comment:
```suggestion
|virtualColumns|A JSON list of [virtual columns](./virtual-columns.md)
available to use in `searchDimensions`.| no (default none)|
```
##########
docs/querying/groupbyquery.md:
##########
@@ -86,6 +86,7 @@ Following are main parts to a groupBy query:
|queryType|This String should always be "groupBy"; this is the first thing
Druid looks at to figure out how to interpret the query|yes|
|dataSource|A String or Object defining the data source to query, very similar
to a table in a relational database. See
[DataSource](../querying/datasource.md) for more information.|yes|
|dimensions|A JSON list of dimensions to do the groupBy over; or see
[DimensionSpec](../querying/dimensionspecs.md) for ways to extract dimensions.
|yes|
+|virtualColumns|Define any [virtual columns](./virtual-columns.md) to be
available to use as `dimensions` or referenced as inputs to `aggregations` or
`postAggregations`.| no (default none)|
Review Comment:
```suggestion
|virtualColumns|A JSON list of [virtual columns](./virtual-columns.md). You
can reference the virtual columns in `dimensions`, `aggregations`, or
`postAggregations`.| no (default none)|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
