rohangarg opened a new pull request, #12923:
URL: https://github.com/apache/druid/pull/12923

   Adds `sqlQuery/planningTimeMs` metric per SQL query which computes the time 
it takes to build a native query from the SQL query.
   While comparing the perf of native to SQL API for the same query, users tend 
to check the extra time taken by planning stage of the SQL. Currently, that 
time is estimated as the difference between running the SQL and then running 
the native query using EXPLAIN. To find the exact difference, the `query/time` 
metrics of both SQL and native queries are compared.
   Further, for SQL query workloads there is no easy visiblity into the 
holistic planning time.
   
   This PR has:
   - [x] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [x] added documentation for new or modified features or behaviors.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to