gianm commented on PR #12918: URL: https://github.com/apache/druid/pull/12918#issuecomment-1224300001
I'm looking at the LGTM issues. The commit https://github.com/apache/druid/pull/12918/commits/277a5e8bb33c0f3c21f9a592083ee8e0cb4034af removes the useless null check (it was a stageId check in ControllerImpl). It also adds additional validation to task IDs to attempt to satisfy the check for uncontrolled data in a path expression. As I mentioned earlier, these IDs are already checked, so I don't think there's _really_ a problem. The changes are about trying to make sure LGTM sees it the same way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
