rohangarg commented on code in PR #12915: URL: https://github.com/apache/druid/pull/12915#discussion_r953363101
########## core/src/main/java/org/apache/druid/java/util/emitter/core/EventMap.java: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.java.util.emitter.core; + +import com.fasterxml.jackson.databind.annotation.JsonSerialize; + +import java.util.HashMap; +import java.util.Map; + +/** + * EventMap is a hash map implementation. It can be safely serialzed to JSON using Jackson serializer as it + * respects the polymorphic annotations on entires (unlike standard Map). The example of polymorphic class is a query + * interface, where different native query types are resolved by additional field called "queryType". + * This implementation ensures that the annotation on the values are respected during serialization. + */ +@JsonSerialize(using = EventMapSerializer.class) +public class EventMap extends HashMap<String, Object> Review Comment: Thanks for the explanations Bart and Frank! I agree that it won't break compatibility since the callers of the `Event` impls. can still cast the `EventMap` returned by `toMap()` to a `Map<String, Object>` and that's the only contract for `PublicApi` annotated interfaces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
