rohangarg commented on PR #12948: URL: https://github.com/apache/druid/pull/12948#issuecomment-1225934327
@gianm @cryptoe : I tried some experiment with `PolyBind` locally and wasn't able to make it work out of the box due to errors with multiple bindings via multiple choices to the same interface. I added a new method to do named binding in `PolyBind` and was able to construct a test : https://gist.github.com/rohangarg/838489720d0ef5093fe60df7f7b922d7 Can you please take a look and see if it seems right and that fits the `StorageConnector` usecase? One thing I'm not sure right now is of the `Singleton` nature of objects created by the `ConfiggedProvider`. BTW, the investigation need not block the current changes in this PR from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
