eshengit commented on code in PR #12961:
URL: https://github.com/apache/druid/pull/12961#discussion_r956462539
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaRecordSupplier.java:
##########
@@ -272,8 +280,8 @@ private static KafkaConsumer<byte[], byte[]>
getKafkaConsumer(ObjectMapper sorti
ClassLoader currCtxCl = Thread.currentThread().getContextClassLoader();
try {
Thread.currentThread().setContextClassLoader(KafkaRecordSupplier.class.getClassLoader());
- Deserializer keyDeserializerObject = getKafkaDeserializer(props,
"key.deserializer");
- Deserializer valueDeserializerObject = getKafkaDeserializer(props,
"value.deserializer");
+ Deserializer keyDeserializerObject = getKafkaDeserializer(props,
"key.deserializer", true);
+ Deserializer valueDeserializerObject = getKafkaDeserializer(props,
"value.deserializer", true);
Review Comment:
@abhishekagarwal87 I just knew I need to go through our company's process to
contribute to open source. I will reopen when I get approval. will keep you
posted. thank you for reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
