paul-rogers commented on code in PR #12957:
URL: https://github.com/apache/druid/pull/12957#discussion_r957587884
##########
it.sh:
##########
@@ -18,17 +18,20 @@
# Utility script for running the new integration tests, since the Maven
# commands are unwieldy.
+set -e
export DRUID_DEV=$(cd $(dirname $0) && pwd)
function usage
{
- cat <<EOF
+ cat <<EOF
Review Comment:
What is our standard indentation in scripts? It is 2 in Java. I think I saw
it as 4 in other scripts, though I might be mistaken.
##########
integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/config/ClusterConfigTest.java:
##########
@@ -85,15 +79,6 @@ public void testYaml() throws FileNotFoundException
assertEquals("http://localhost:8888";, service.clientUrl());
assertEquals("http://localhost:8888";, resolved.routerUrl());
Review Comment:
Can I ask you to comment this out and not remove it? The functionality needs
to be tested; let's not use the code itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
