gianm commented on code in PR #12987:
URL: https://github.com/apache/druid/pull/12987#discussion_r958771742
##########
processing/src/main/java/org/apache/druid/frame/file/FrameFile.java:
##########
@@ -63,13 +57,18 @@
*
* - 2 bytes: {@link FrameFileWriter#MAGIC}
* - NNN bytes: sequence of {@link FrameFileWriter#MARKER_FRAME} followed by
one compressed frame (see {@link Frame})
+ * - 1 byte: {@link FrameFileWriter#MARKER_NO_MORE_FRAMES}
Review Comment:
We've got this covered: there's version bytes for each frame, & if we need
to version the entire frame file format, we can increment the MAGIC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
