clintropolis commented on code in PR #13022:
URL: https://github.com/apache/druid/pull/13022#discussion_r965172651
##########
processing/src/main/java/org/apache/druid/query/Query.java:
##########
@@ -124,22 +124,130 @@ default QueryContext getQueryContext()
return null;
}
- <ContextType> ContextType getContextValue(String key);
Review Comment:
hmm, actually I guess this is an `@ExtensionPoint`, we should probably leave
the old methods here to not be backwards incompatible
##########
processing/src/main/java/org/apache/druid/query/QueryContexts.java:
##########
@@ -604,18 +644,31 @@ private QueryContexts()
{
}
- static <T, E extends Enum<E>> E parseEnum(Query<T> query, String key,
Class<E> clazz, E defaultValue)
Review Comment:
this class is also marked `@PublicApi` and so we should ideally leave the
signatures in place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
