FrankChen021 commented on code in PR #13034: URL: https://github.com/apache/druid/pull/13034#discussion_r965572835
########## docs/development/extensions-contrib/prometheus.md: ########## @@ -43,7 +43,7 @@ All the configuration parameters for the Prometheus emitter are under `druid.emi |`druid.emitter.prometheus.addHostAsLabel`|Flag to include the hostname as a prometheus label.|no|false| |`druid.emitter.prometheus.addServiceAsLabel`|Flag to include the druid service name (e.g. `druid/broker`, `druid/coordinator`, etc.) as a prometheus label.|no|false| |`druid.emitter.prometheus.pushGatewayAddress`|Pushgateway address. Required if using Pushgateway strategy|no|none| - +|`druid.emitter.prometheus.flushPeriod`|Emit metrics to Pushgateway every `flushPeriod` seconds. Required if `pushgateway` strategy is used.|no|15| Review Comment: `flushPeriod` is what I suggest because it's the same property name used in graphite emitter. I think maybe we can unify some configurations and the scheduler among all emitters in someday. @kfaraz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
