599166320 commented on code in PR #13031:
URL: https://github.com/apache/druid/pull/13031#discussion_r967662342
##########
processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java:
##########
@@ -252,7 +260,295 @@ public void cleanup(Iterator<ScanResultValue>
iterFromMake)
))
);
}
+ private Sequence<ScanResultValue> getScanOrderByResultValueSequence(
Review Comment:
>
Today I thought about why I changed it to this way in the first place.
Take a look, in fact `orderByTimeLimit` and `orderByMultiColumnLimit` are
similar.
```
//past execution path
if(orderByTimeLimit){
//...
}else{
//...
}
//current execution path
if(orderByMultiColumnLimit){
//
}else if(orderByTimeLimit){
///
}else{
///
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
