FrankChen021 commented on PR #13022: URL: https://github.com/apache/druid/pull/13022#issuecomment-1243144052
@paul-rogers I think the new APIs you proposed is what I want -- that is there's only one place for these `getXXX` methods. ```java final QueryContext queryContext = query.queryContext(); final String timestampStringFromContext = queryContext.getString(CTX_KEY_FUDGE_TIMESTAMP, ""); final boolean flag = queryContext.enableJoinFilterRewrite(); ``` Let me remove all newly addde `getContextXXXX` methods in this PR from `Query` interface, and replace all reference to these methods to what you suggest as ```java final String timestampStringFromContext = QueryContexts.getAsString(query, CTX_KEY_FUDGE_TIMESTAMP, ""); ``` I will do this ASAP so that it won't block other PRs for long time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
