clintropolis opened a new pull request, #13079: URL: https://github.com/apache/druid/pull/13079
### Description This PR fixes some issues encountered with nested column objects with key names containing newlines or commas, which while valid JSON, are not cool with the way the `meta.smoosh` file currently works. To remedy this, the smoosh file now escapes commas and newlines when writing the `meta.smoosh` file, and unescapes them upon mapping. This PR also fixes an issue with the jsonpath and jq parsers when handling empty keys, which are also valid JSON property names. They were both a bit overly strict, and now should allow them if contained in syntax appropriate quotes. <hr> This PR has: - [ ] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
