imply-cheddar commented on code in PR #13087:
URL: https://github.com/apache/druid/pull/13087#discussion_r971411537
##########
server/src/main/java/org/apache/druid/curator/CuratorModule.java:
##########
@@ -97,6 +99,21 @@ public CuratorFramework makeCurator(ZkEnablementConfig
zkEnablementConfig, Curat
framework.getUnhandledErrorListenable().addListener((message, e) -> {
log.error(e, "Unhandled error in Curator, stopping server.");
+ final Thread halter = new Thread(
+ () -> {
+ try {
+ Threads.sleepFor(10, TimeUnit.SECONDS);
Review Comment:
Generally speaking, this failure mode should only happen at startup. I
suppose it's possible for unhandled background exceptions to make it out later
on in the lifetime of the process, but I'm only familiar with these happening
at startup and indicating problems with ZK connectivity/configurations. As
such, I don't think that "finish currently executing queries" is really a
thing. That said, if you feel strongly about it, 30s is better than nothing
existing so I'll do it to get it merged :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
