paul-rogers commented on PR #12905: URL: https://github.com/apache/druid/pull/12905#issuecomment-1248751133
@abhishekagarwal87, thanks for the clarification. I agree that the analysis of `INSERT` and `REPLACE` will differ. That difference will appear in the next step: when we move the analysis out of these planner classes and into the Calcite planner. This particular PR sets us up to make the shift of the analysis code out of the various ad-hoc places where it now resides into a customized validator. (And, we want to do that so that the validation can use catalog information available via the Calcite metadata mechanism.) Thanks for the approval. There was one build failure due to a race condition fixed in a PR a few days back. Rebased on the latest master to pick up that change and @imply-cheddar's change. Resolved the conflict with @imply-cheddar's change. Let's verify that the build works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
