FrankChen021 commented on code in PR #13086:
URL: https://github.com/apache/druid/pull/13086#discussion_r977126650
##########
extensions-contrib/compressed-bigdecimal/src/main/java/org/apache/druid/compressedbigdecimal/CompressedBigDecimal.java:
##########
@@ -274,13 +276,74 @@ protected static <S> int signumInternal(int size, S rhs,
ToIntBiFunction<S, Inte
/* (non-Javadoc)
* @see java.lang.Comparable#compareTo(java.lang.Object)
*/
+
@Override
public int compareTo(CompressedBigDecimal o)
+ {
+ return compareTo(o, false);
+ }
+ public int compareTo(CompressedBigDecimal o, boolean expectOptimized)
Review Comment:
if it's called by the UT only, usually we declare its visibility as package
level, and use `VisibileForTesting` annotation to make it more intuitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
