clintropolis commented on PR #12277: URL: https://github.com/apache/druid/pull/12277#issuecomment-1258886843
>Just looked again at the FrontCodedIndexBenchmark and I see the GenericIndexed in there too. I can't help but wonder if the differences there are actually from the fact that FrontCoded is dealing with UTF8 bytes instead of String. I.e. all of the glut of dealing with String is equivalent to the glut of the extra objects and they are just equaling each other out. If that's the case, then there's even more benefit to be had from the FrontCodedIndexBenchmark. Yeah, I don't think `FrontCodedIndexed` has that much more garbage than regular string using `GenericIndexed`, a bit more - but not a ton. I would agree that there is a lot of room for improvement (probably with `GenericIndexed` string columns too). In `FrontCodedIndexBenchmark`, the `FrontCodedIndexed` is converting values to string and from bytebuffer as well, so it should be apples to apples I think, mostly. My earlier implementation of `FrontCodedIndexed` was `Indexed<String>`, since this PR predated #12517, you can see the older numbers here https://github.com/apache/druid/pull/12277#issuecomment-1255538371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
