rash67 opened a new pull request, #13154:
URL: https://github.com/apache/druid/pull/13154
### Description
Refactor CompressedBigDecimal Sum/Min/Max
This refactors several of the classes for production code as well as
shared test cases across all 3 functions.
Every case of production and test instances that exist for all three
functions has a base class. Often this doesn't reduce loc significantly,
but ensures that common behavior can be controlled in one location
(eg AggregatorFactory.finalizeComputation(),
AggregatorFactory.getCacheKey)
##### Key changed/added classes in this PR
All new classes in this commit matching *Base both in production code
and test code.
<hr>
This PR has:
- [X] been self-reviewed.
- [X ] added documentation for new or modified features or behaviors.
- [X ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ X] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ X] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ X] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ X] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
