This is an automated email from the ASF dual-hosted git repository.
kfaraz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new b07f01d645 Set useMaxMemoryEstimates=false by default (#13178)
b07f01d645 is described below
commit b07f01d645fe23dfa8d35b5588b3656b0c36cdce
Author: Kashif Faraz <[email protected]>
AuthorDate: Tue Oct 4 15:04:23 2022 +0530
Set useMaxMemoryEstimates=false by default (#13178)
A value of `false` denotes that the new flow with improved estimates will
be used.
---
.../src/main/java/org/apache/druid/indexing/common/task/Tasks.java | 4 +---
.../org/apache/druid/indexing/common/task/AppenderatorsTest.java | 6 +++---
.../apache/druid/indexing/common/task/BatchAppenderatorsTest.java | 6 +++---
.../apache/druid/indexing/common/task/TestAppenderatorsManager.java | 6 +++---
4 files changed, 10 insertions(+), 12 deletions(-)
diff --git
a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/Tasks.java
b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/Tasks.java
index e009394226..90b7526977 100644
---
a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/Tasks.java
+++
b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/Tasks.java
@@ -46,15 +46,13 @@ public class Tasks
public static final long DEFAULT_LOCK_TIMEOUT_MILLIS =
TimeUnit.MINUTES.toMillis(5);
public static final boolean DEFAULT_FORCE_TIME_CHUNK_LOCK = true;
public static final boolean DEFAULT_STORE_COMPACTION_STATE = false;
- public static final boolean DEFAULT_USE_MAX_MEMORY_ESTIMATES = true;
+ public static final boolean DEFAULT_USE_MAX_MEMORY_ESTIMATES = false;
public static final String PRIORITY_KEY = "priority";
public static final String LOCK_TIMEOUT_KEY = "taskLockTimeout";
public static final String FORCE_TIME_CHUNK_LOCK_KEY = "forceTimeChunkLock";
public static final String USE_SHARED_LOCK = "useSharedLock";
public static final String STORE_EMPTY_COLUMNS_KEY = "storeEmptyColumns";
- public static final String DYNAMIC_CONFIG_PROVIDER_KEY =
"dynamicConfigProviderKey";
-
/**
* Context flag denoting if maximum possible values should be used to
estimate
diff --git
a/indexing-service/src/test/java/org/apache/druid/indexing/common/task/AppenderatorsTest.java
b/indexing-service/src/test/java/org/apache/druid/indexing/common/task/AppenderatorsTest.java
index 914f1266d7..c7b312f190 100644
---
a/indexing-service/src/test/java/org/apache/druid/indexing/common/task/AppenderatorsTest.java
+++
b/indexing-service/src/test/java/org/apache/druid/indexing/common/task/AppenderatorsTest.java
@@ -246,7 +246,7 @@ public class AppenderatorsTest
indexMerger,
rowIngestionMeters,
new ParseExceptionHandler(rowIngestionMeters, false,
Integer.MAX_VALUE, 0),
- true
+ false
);
break;
case "CLOSED_SEGMENTS":
@@ -261,7 +261,7 @@ public class AppenderatorsTest
indexMerger,
rowIngestionMeters,
new ParseExceptionHandler(rowIngestionMeters, false,
Integer.MAX_VALUE, 0),
- true
+ false
);
break;
@@ -277,7 +277,7 @@ public class AppenderatorsTest
indexMerger,
rowIngestionMeters,
new ParseExceptionHandler(rowIngestionMeters, false,
Integer.MAX_VALUE, 0),
- true
+ false
);
break;
default:
diff --git
a/indexing-service/src/test/java/org/apache/druid/indexing/common/task/BatchAppenderatorsTest.java
b/indexing-service/src/test/java/org/apache/druid/indexing/common/task/BatchAppenderatorsTest.java
index f378a53a4d..c86636148b 100644
---
a/indexing-service/src/test/java/org/apache/druid/indexing/common/task/BatchAppenderatorsTest.java
+++
b/indexing-service/src/test/java/org/apache/druid/indexing/common/task/BatchAppenderatorsTest.java
@@ -258,7 +258,7 @@ public class BatchAppenderatorsTest
Integer.MAX_VALUE,
0
),
- true
+ false
);
break;
case "CLOSED_SEGMENTS":
@@ -281,7 +281,7 @@ public class BatchAppenderatorsTest
Integer.MAX_VALUE,
0
),
- true
+ false
);
break;
@@ -305,7 +305,7 @@ public class BatchAppenderatorsTest
Integer.MAX_VALUE,
0
),
- true
+ false
);
break;
default:
diff --git
a/indexing-service/src/test/java/org/apache/druid/indexing/common/task/TestAppenderatorsManager.java
b/indexing-service/src/test/java/org/apache/druid/indexing/common/task/TestAppenderatorsManager.java
index 0fc7943377..c4d4364f43 100644
---
a/indexing-service/src/test/java/org/apache/druid/indexing/common/task/TestAppenderatorsManager.java
+++
b/indexing-service/src/test/java/org/apache/druid/indexing/common/task/TestAppenderatorsManager.java
@@ -90,7 +90,7 @@ public class TestAppenderatorsManager implements
AppenderatorsManager
cachePopulatorStats,
rowIngestionMeters,
parseExceptionHandler,
- true
+ useMaxMemoryEstimates
);
return realtimeAppenderator;
}
@@ -121,7 +121,7 @@ public class TestAppenderatorsManager implements
AppenderatorsManager
indexMerger,
rowIngestionMeters,
parseExceptionHandler,
- true
+ useMaxMemoryEstimates
);
}
@@ -181,7 +181,7 @@ public class TestAppenderatorsManager implements
AppenderatorsManager
indexMerger,
rowIngestionMeters,
parseExceptionHandler,
- true
+ useMaxMemoryEstimates
);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
