abhishekagarwal87 commented on issue #13152: URL: https://github.com/apache/druid/issues/13152#issuecomment-1271460821
I can't spot the `sorting` operation in the runner. The data from physical segments are already sorted by time. That ordering is used to decide if the data needs to be reversed. That's why we are only passing the `type of ordering (Asc/desc)` down the `makeCursors` call and not the columns on which to order by. Are you suggesting passing the columns to `makeCursors` and then doing the sorting in `RowBasedStorageAdapter`? Or you are suggesting doing the sorting in the `createRunner` method itself? The former seems a simpler approach to implement. We will just materialize the rows into a list and sort the list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
