cheddar commented on code in PR #13133:
URL: https://github.com/apache/druid/pull/13133#discussion_r992881263
##########
processing/src/main/java/org/apache/druid/segment/serde/DictionaryEncodedStringIndexSupplier.java:
##########
@@ -280,8 +351,10 @@ public ImmutableBitmap next()
private void findNext()
{
- while (next < 0 && iterator.hasNext()) {
- ByteBuffer nextValue = iterator.next();
+ // if the size of in-filter values is less than the threshold
percentage of dictionary size, then use binary search
+ // based lookup per value. The algorithm works well for smaller
number of values.
Review Comment:
I *think* this comment is a bit stale now as the choice of which algorithm
to use happens earlier in the code than this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
