clintropolis commented on code in PR #13214: URL: https://github.com/apache/druid/pull/13214#discussion_r992887728
########## core/src/main/java/org/apache/druid/math/expr/vector/UnivariateFunctionVectorValueProcessor.java: ########## @@ -74,5 +76,7 @@ public final ExprEvalVector<TOutput> evalVector(Expr.VectorInputBinding bindings abstract void processIndex(TInput input, int i); + abstract void processNull(int i); Review Comment: it would have to return an object since we don't know if the value is `double` or `long`. Maybe the better thing to do is abstract out `long` and `double` versions of value processors and just have the same-ish code between them, though that's a bit more invasive of a change so i'm hesitant to make it right now. Would you be ok if i look into this as a follow-up PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
