clintropolis commented on code in PR #13209:
URL: https://github.com/apache/druid/pull/13209#discussion_r992901960
##########
core/src/main/java/org/apache/druid/math/expr/vector/VectorStringProcessors.java:
##########
@@ -32,32 +33,35 @@ public static <T> ExprVectorProcessor<T>
concat(Expr.VectorInputBindingInspector
{
final ExprVectorProcessor processor;
if (NullHandling.sqlCompatible()) {
- processor = new StringOutStringsInFunctionVectorProcessor(
+ processor = new ObjectOutObjectsInFunctionVectorProcessor(
left.buildVectorized(inspector),
right.buildVectorized(inspector),
- inspector.getMaxVectorSize()
+ inspector.getMaxVectorSize(),
+ ExpressionType.STRING
)
{
@Nullable
@Override
- protected String processValue(@Nullable String leftVal, @Nullable
String rightVal)
+ protected String processValue(@Nullable Object leftVal, @Nullable
Object rightVal)
{
// in sql compatible mode, nulls are handled by super class and
never make it here...
- return leftVal + rightVal;
+ return leftVal + (String) rightVal;
Review Comment:
same comment as
https://github.com/apache/druid/pull/13209#discussion_r992901606 about why is
safe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
