paul-rogers commented on PR #13191: URL: https://github.com/apache/druid/pull/13191#issuecomment-1276797602
Looks great. Thanks also for adding all the back-ticks. One small improvement. I like the list items. When reading the first, my immediate question is "which config key"? The other nit is we need to decide on what we call the thingies in the query context. I've seem "parameter" (but, easily confused with a query parameter), "entry", "value" and now "configuration". Might I suggest "entry" for the whole thing and "key" for the name? Those don't conflict with other common terms in Druid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
