didip commented on code in PR #13027:
URL: https://github.com/apache/druid/pull/13027#discussion_r996613354
##########
core/src/main/java/org/apache/druid/data/input/impl/CloudObjectInputSource.java:
##########
@@ -108,9 +112,40 @@ public List<CloudObjectLocation> getObjects()
@Nullable
@JsonProperty
@JsonInclude(JsonInclude.Include.NON_NULL)
- public String getFilter()
+ public String getObjectGlob()
{
- return filter;
+ return objectGlob;
+ }
+
+ /**
+ * Strips out blob store's protocol and bucket from {@link #getObjectGlob}.
+ * This is to reduce user errors when crafting a objectGlob.
Review Comment:
I agree with you, let's not be too clever.
##########
docs/ingestion/native-batch-input-source.md:
##########
@@ -63,7 +63,7 @@ Sample specs:
"type": "index_parallel",
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
