LakshSingla commented on PR #13231: URL: https://github.com/apache/druid/pull/13231#issuecomment-1281865295
> I am not sure I agree with the approach here. It seems an overkill to do a complex regex replace just to not log some specific fields. Yeah, but since the SQL was a string, there seemed to be no other alternative, esp. since druid planner isn't available in the Peons. > I think the better thing to do is to just continue logging the secrets. This would be a good reason to encourage users to provide secrets using a EnvironmentVariableDynamicConfigProvider or similar. We should then update the documentation since the method here only masks it in the logs in the ExecutorLifecycle class. Any deserialization of the controller's task spec would reveal the query. > If we do however feel the need to this, we should look for a simpler approach All of the approaches (that I was able to think off) would be based on a text search and replace, so in my opinion, we can choose any one of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
