clintropolis commented on code in PR #12277:
URL: https://github.com/apache/druid/pull/12277#discussion_r1000172066
##########
processing/src/main/java/org/apache/druid/segment/StringDimensionMergerV9.java:
##########
@@ -71,6 +76,15 @@ public StringDimensionMergerV9(
)
{
super(dimensionName, indexSpec, segmentWriteOutMedium, capabilities,
progress, closer);
+ if (capabilities.hasSpatialIndexes()) {
+ Preconditions.checkArgument(
+
StringEncodingStrategy.UTF8.equals(indexSpec.getStringDictionaryEncoding().getType()),
+ StringUtils.format(
+ "Spatial indexes are incompatible with [%s] encoded
dictionaries",
+ indexSpec.getStringDictionaryEncoding().getType()
+ )
+ );
Review Comment:
i've fixed this by implementing the `get` method for the dictionary writer
so this check has now been removed and `SpatialIndex` is now supported when
using front-coding (also added tests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
