gianm commented on PR #13040: URL: https://github.com/apache/druid/pull/13040#issuecomment-1287552292
> while reviewing this i started to wonder if `basePersistDirectory` should be on the `AppenderatorConfig` at all anymore since its never set directly so seems a bit strange as part of the base class, but looking into how painful that would be to move somewhere for not much gain it doesn't really seem worth the effort That was my thinking as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
