Fryuni commented on PR #13156:
URL: https://github.com/apache/druid/pull/13156#issuecomment-1292666488

   @abhishekagarwal87 
   > may not be an issue but is there a limit in k8s on how large the env 
variable value can be? The task JSON could be large.
   
   I just checked the defaults for K8s, k3s, microk8s, GKE, and EKS:
   - A configMap value is limited to 1MiB
   - Similarly, an inline `env` value is limited to 1MiB
   - The entire final command passed to the container (command + arguments + 
ENVs) is limited to the `ARG_MAX` configuration of the host node, which 
defaults to 2MiB on Linux.
   
   None of our tasks reach close to a mebibyte, but if that could be a problem, 
then the best would be retrieving the task from the coordinator.
   
   Mounting a config map instead of passing as an env var is cleaner IMHO, but 
would only make a difference regarding limits if there were multiple envs 
smaller than 1MiB that combined go over 2MiB.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to