kfaraz commented on code in PR #13197:
URL: https://github.com/apache/druid/pull/13197#discussion_r1010207688
##########
server/src/test/java/org/apache/druid/server/coordinator/RunRulesTest.java:
##########
@@ -119,35 +118,39 @@ public void
testOneTierTwoReplicantsWithStrictReplicantLimit()
)).atLeastOnce();
EasyMock.replay(databaseRuleManager);
- DruidCluster druidCluster = DruidClusterBuilder
+ // server1 has all the segments already loaded
+ final DruidServer server1 =
+ new DruidServer("server1", "hostNorm", null, 1000,
ServerType.HISTORICAL, "normal", 0);
+ usedSegments.forEach(server1::addDataSegment);
+
+ final DruidServer server2 =
+ new DruidServer("server2", "hostNorm", null, 1000,
ServerType.HISTORICAL, "normal", 0);
+
+ final DruidCluster druidCluster = DruidClusterBuilder
.newBuilder()
.addTier(
"normal",
- new ServerHolder(
- new DruidServer("serverNorm", "hostNorm", null, 1000,
ServerType.HISTORICAL, "normal", 0)
- .toImmutableDruidServer(),
- mockPeon
- ),
- new ServerHolder(
- new DruidServer("serverNorm2", "hostNorm2", null, 1000,
ServerType.HISTORICAL, "normal", 0)
- .toImmutableDruidServer(),
- mockPeon
- )
- )
- .build();
+ new ServerHolder(server1.toImmutableDruidServer(), mockPeon),
+ new ServerHolder(server2.toImmutableDruidServer(), mockPeon)
+ ).build();
ListeningExecutorService exec =
MoreExecutors.listeningDecorator(Executors.newFixedThreadPool(1));
BalancerStrategy balancerStrategy = new
CostBalancerStrategyFactory().createBalancerStrategy(exec);
DruidCoordinatorRuntimeParams params =
makeCoordinatorRuntimeParams(druidCluster, balancerStrategy)
-
.withDynamicConfigs(CoordinatorDynamicConfig.builder().withMaxSegmentsToMove(5).withMaxNonPrimaryReplicantsToLoad(10).build())
+ .withDynamicConfigs(
+ CoordinatorDynamicConfig
+ .builder()
+ .withMaxNonPrimaryReplicantsToLoad(10)
+ .build()
+ )
.build();
DruidCoordinatorRuntimeParams afterParams = ruleRunner.run(params);
CoordinatorStats stats = afterParams.getCoordinatorStats();
- Assert.assertEquals(34L, stats.getTieredStat("assignedCount", "normal"));
- Assert.assertEquals(10L,
stats.getGlobalStat("totalNonPrimaryReplicantsLoaded"));
+ // There are 24 under-replicated segments, but only 10 replicas are
assigned
Review Comment:
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
