zachjsh commented on code in PR #13165: URL: https://github.com/apache/druid/pull/13165#discussion_r1012272293
########## extensions-core/druid-catalog/src/main/java/org/apache/druid/catalog/http/MoveColumn.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.catalog.http; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; + +import javax.annotation.Nullable; + +import java.util.Objects; + +/** + * JSON payload for the reorder column API. + */ +public class MoveColumn extends TableEditRequest +{ + public enum Position + { + FIRST, + LAST, + BEFORE, + AFTER + } + + @JsonProperty + public final String column; + @JsonProperty + public final Position where; + @Nullable + @JsonProperty + public final String anchor; + + @JsonCreator + public MoveColumn( + @JsonProperty("column") final String column, + @JsonProperty("where") final Position where, Review Comment: I see we are doing the validation in the TableEditor class. I think its best to move the validation as high up in the stack as possible, and then users can assume that the object has already been validated. Maybe the validation logic should at least live in the TableEditRequest classes themselves, at the very least. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
