techdocsmith commented on code in PR #13316: URL: https://github.com/apache/druid/pull/13316#discussion_r1014374393
########## docs/operations/metrics.md: ########## @@ -118,53 +118,52 @@ Metrics may have additional dimensions beyond those listed above. Review Comment: In line 115 & 116, there should only be one `|` before `N/A`. It's currently making 4 columns and breaking the table. Unless there is a missing `Dimensions` header. for the empty column. not sure. It looks like the Dimensions column is empty for the following table lines 121 to 132. I'm not sure what the value is for having a column with all the dimension cells being empty. ########## docs/operations/metrics.md: ########## @@ -118,53 +118,52 @@ Metrics may have additional dimensions beyond those listed above. Review Comment: Also not 100% sure why this table is separate, but I don't think that was part of your PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
