rohangarg commented on code in PR #13269: URL: https://github.com/apache/druid/pull/13269#discussion_r1016519903
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/guice/MSQDurableStorageModule.java: ########## @@ -47,6 +51,7 @@ public class MSQDurableStorageModule implements DruidModule @Inject private Properties properties; + // Dummy constructor so that it can get injected dynamically at runtime Review Comment: discussed offline - removed constructors and moved the properties injection to a separate method like other extensions. thanks for the changes! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
