AmatyaAvadhanula commented on code in PR #13331:
URL: https://github.com/apache/druid/pull/13331#discussion_r1017540567
##########
extensions-contrib/prometheus-emitter/src/main/resources/defaultMetrics.json:
##########
@@ -53,9 +53,10 @@
"ingest/merge/time" : { "dimensions" : ["dataSource"], "type" : "timer",
"conversionFactor": 1000.0, "help": "Seconds spent merging intermediate
segments" },
"ingest/merge/cpu" : { "dimensions" : ["dataSource"], "type" : "timer",
"conversionFactor": 1000000000.0, "help": "Cpu time in Seconds spent on merging
intermediate segments."},
- "ingest/kafka/lag" : { "dimensions" : ["dataSource"], "type" : "gauge",
"help": "Total lag between the offsets consumed by the Kafka indexing tasks and
latest offsets in Kafka brokers across all partitions. Minimum emission period
for this metric is a minute."},
- "ingest/kafka/maxLag" : { "dimensions" : ["dataSource"], "type" : "gauge",
"help": "Max lag between the offsets consumed by the Kafka indexing tasks and
latest offsets in Kafka brokers across all partitions. Minimum emission period
for this metric is a minute."},
- "ingest/kafka/avgLag" : { "dimensions" : ["dataSource"], "type" : "gauge",
"help": "Average lag between the offsets consumed by the Kafka indexing tasks
and latest offsets in Kafka brokers across all partitions. Minimum emission
period for this metric is a minute."},
+ "ingest/kafka/lag" : { "dimensions" : ["dataSource", "stream"], "type" :
"gauge", "help": "Total lag between the offsets consumed by the Kafka indexing
tasks and latest offsets in Kafka brokers across all partitions. Minimum
emission period for this metric is a minute."},
+ "ingest/kafka/maxLag" : { "dimensions" : ["dataSource", "stream"], "type" :
"gauge", "help": "Max lag between the offsets consumed by the Kafka indexing
tasks and latest offsets in Kafka brokers across all partitions. Minimum
emission period for this metric is a minute."},
+ "ingest/kafka/avgLag" : { "dimensions" : ["dataSource", "stream"], "type" :
"gauge", "help": "Average lag between the offsets consumed by the Kafka
indexing tasks and latest offsets in Kafka brokers across all partitions.
Minimum emission period for this metric is a minute."},
+ "ingest/kafka/avgLag" : { "dimensions" : ["dataSource", "stream",
"partition"], "type" : "gauge", "help": "Partition-wise lag between the offsets
consumed by the Kafka indexing tasks and latest offsets in Kafka brokers.
Minimum emission period for this metric is a minute."},
Review Comment:
Sorry. fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
