gianm commented on code in PR #13334:
URL: https://github.com/apache/druid/pull/13334#discussion_r1018750463
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -405,9 +394,16 @@ public String getType()
}
@Override
- public boolean canAlsoHandle(Notice otherNotice)
+ public int hashCode()
{
- return otherNotice.getType().equals(TYPE);
+ return 0;
+ }
+
+ @Override
+ public boolean equals(Object obj)
+ {
+ // All RunNotices are the same. They are de-duplicated on insertion into
the NoticesQueue "notices".
+ return obj != null && obj.getClass().equals(RunNotice.class);
Review Comment:
I think a singleton makes sense, I can add that tomorrow when fixing the
build issues.
However then `lastRunTime` couldn't be a field in `RunNotice`, since if
`RunNotice` is a singleton, it's a singleton across all supervisors for all
datasources. I'll look into whether it's still needed at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
