adarshsanjeev commented on code in PR #13205:
URL: https://github.com/apache/druid/pull/13205#discussion_r1022607933
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/kernel/controller/ControllerStageTracker.java:
##########
@@ -252,14 +255,17 @@ ControllerStagePhase addResultKeyStatisticsForWorker(
}
try {
- if (workersWithResultKeyStatistics.add(workerNumber)) {
- resultKeyStatisticsCollector.addAll(snapshot);
+ if (workersWithFinishedReport.add(workerNumber)) {
+ aggregatedKeyStatistics.addAll(aggregatedKeyStatistics);
- if (workersWithResultKeyStatistics.size() == workerCount) {
- generateResultPartitionsAndBoundaries();
+ if (workersWithFinishedReport.size() == workerCount) {
+ // All workers have sent the report.
+ // Transition to MERGING_STATISTICS state to queue fetch clustering
statistics from workers.
+ transitionTo(ControllerStagePhase.MERGING_STATISTICS);
- // Phase can become FAILED after
generateResultPartitionsAndBoundaries, if there were too many partitions.
- if (phase != ControllerStagePhase.FAILED) {
+ if (!stageDef.doesShuffle()) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
