churromorales commented on PR #13339: URL: https://github.com/apache/druid/pull/13339#issuecomment-1317974161
One other thing, I have run into issues like this when having tasks handle multiple partitions. https://github.com/apache/druid/issues/8139 I personally think the default should do the most sensible thing, instead of defaulting to 1, just to satisfy a small set of users. 1 is the safest thing to do, but if you have more partitions than tasks, you are not necessarily safe either. Now I haven’t checked if this happens in the latest Druid version, we stopped having a task handle more than one partition, so I never looked into this issue again after it bit us enough times. Also this is part of the supervisor, so I believe the change set is agnostic to the task runner implementation. I don’t see an easy way to make this work just for mm-less without a hack. Anyways let me know your thoughts. I do agree that in a mm-less world having tasks == partitions may not be an ideal default. But in most deployments, 1 as a default doesn’t make much sense either. I guess there is no “right answer” here :(. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
