imply-cheddar opened a new pull request, #13378: URL: https://github.com/apache/druid/pull/13378
Fixes #13377 ### Description We added compression to the latest/first pair storage, but the code change was forcing new things to be persisted with the new format, meaning that any segment created with the new code cannot be read by the old code. Instead, we need to default to creating the old format and then remove that default in a future version. This introduces a java system property to toggle the compression on, but I do not believe we should publicly document it as it doesn't play well with the runtime.properties. Instead, it's there just for intrepid developers who want to use the functionality/validate it ahead of the next major release. Along with creating the tests for this, it became clear to me that various implementations of ComplexColumn were breaking contract (they were returning "number of cells" for a getter that is documented as returning number of bytes). I also fixed the usages of the method that were expecting number of rows and adjusted the various implementations to return `-1` when they don't know the size. This PR has: - [x] been self-reviewed. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
