techdocsmith commented on code in PR #13245:
URL: https://github.com/apache/druid/pull/13245#discussion_r1025803841


##########
docs/operations/auth-ldap.md:
##########
@@ -22,182 +23,284 @@ title: "LDAP auth"
   ~ under the License.
   -->
 
+You can use [Lightweight Directory Access Protocol 
(LDAP)](https://en.wikipedia.org/wiki/Lightweight_Directory_Access_Protocol) to 
secure access to Apache Druid. This topic describes how to set up Druid 
authentication and authorization with LDAP and LDAP over TLS (LDAPS). The 
examples on this page show the configuration for an Active Directory LDAP 
system.
 
-This page describes how to set up Druid user authentication and authorization 
through LDAP. The first step is to enable LDAP authentication and authorization 
for Druid. You then map an LDAP group to roles and assign permissions to roles.
+The first step is to enable LDAP authentication and authorization for Druid. 
You then map an LDAP group to Druid roles and assign permissions to those 
roles. After you've completed this configuration you can optionally choose to 
enable LDAPS to make LDAP traffic confidential and secure.
 
-## Enable LDAP in Druid
+## Prerequisites
 
-Before starting, verify that the active directory is reachable from the Druid 
Master servers. Command line tools such as `ldapsearch` and `ldapwhoami`, which 
are included with OpenLDAP, are useful for this testing. 
+Before you start to configure LDAP for Druid, test your LDAP connection and 
perform a sample search.
 
-### Check the connection
+### Check your LDAP connection
 
-First test that the basic connection and user credential works. For example, 
given a user `[email protected]`, try:
+Verify that your LDAP connection is working by testing it with user 
credentials. Later in the process you [configure Druid for LDAP 
authentication](#configure-druid-for-ldap-authentication) with this user as the 
`bindUser`.

Review Comment:
   ```suggestion
   Test your LDAP connection to verify it works with user credentials. Later in 
the process you [configure Druid for LDAP 
authentication](#configure-druid-for-ldap-authentication) with this user as the 
`bindUser`.
   ```



##########
docs/operations/auth-ldap.md:
##########
@@ -22,182 +23,284 @@ title: "LDAP auth"
   ~ under the License.
   -->
 
+You can use [Lightweight Directory Access Protocol 
(LDAP)](https://en.wikipedia.org/wiki/Lightweight_Directory_Access_Protocol) to 
secure access to Apache Druid. This topic describes how to set up Druid 
authentication and authorization with LDAP and LDAP over TLS (LDAPS). The 
examples on this page show the configuration for an Active Directory LDAP 
system.
 
-This page describes how to set up Druid user authentication and authorization 
through LDAP. The first step is to enable LDAP authentication and authorization 
for Druid. You then map an LDAP group to roles and assign permissions to roles.
+The first step is to enable LDAP authentication and authorization for Druid. 
You then map an LDAP group to Druid roles and assign permissions to those 
roles. After you've completed this configuration you can optionally choose to 
enable LDAPS to make LDAP traffic confidential and secure.
 
-## Enable LDAP in Druid
+## Prerequisites
 
-Before starting, verify that the active directory is reachable from the Druid 
Master servers. Command line tools such as `ldapsearch` and `ldapwhoami`, which 
are included with OpenLDAP, are useful for this testing. 
+Before you start to configure LDAP for Druid, test your LDAP connection and 
perform a sample search.
 
-### Check the connection
+### Check your LDAP connection
 
-First test that the basic connection and user credential works. For example, 
given a user `[email protected]`, try:
+Verify that your LDAP connection is working by testing it with user 
credentials. Later in the process you [configure Druid for LDAP 
authentication](#configure-druid-for-ldap-authentication) with this user as the 
`bindUser`.
+
+The following example command tests the connection for the user 
`[email protected]`. Insert your LDAP server IP address. Modify the port 
number of your LDAP instance if it listens on a port other than `389`.
 
 ```bash
-ldapwhoami -vv -H ldap://<ip_address>:389  -D"[email protected]" -W
+ldapwhoami -vv -H ldap://ip_address:389  -D "[email protected]" -W
 ```
 
-Enter the password associated with the user when prompted and verify that the 
command succeeded. If it didn't, try the following troubleshooting steps:  
+Enter the password for the user when prompted and verify that the command 
succeeded. If it failed, check the following:
+
+- Make sure you're using the correct port for your LDAP instance.
+- Check whether a network firewall is preventing connections to the LDAP port.

Review Comment:
   ```suggestion
   - Check if a network firewall is preventing connections to the LDAP port.
   ```



##########
docs/operations/auth-ldap.md:
##########
@@ -22,182 +23,284 @@ title: "LDAP auth"
   ~ under the License.
   -->
 
+You can use [Lightweight Directory Access Protocol 
(LDAP)](https://en.wikipedia.org/wiki/Lightweight_Directory_Access_Protocol) to 
secure access to Apache Druid. This topic describes how to set up Druid 
authentication and authorization with LDAP and LDAP over TLS (LDAPS). The 
examples on this page show the configuration for an Active Directory LDAP 
system.
 
-This page describes how to set up Druid user authentication and authorization 
through LDAP. The first step is to enable LDAP authentication and authorization 
for Druid. You then map an LDAP group to roles and assign permissions to roles.
+The first step is to enable LDAP authentication and authorization for Druid. 
You then map an LDAP group to Druid roles and assign permissions to those 
roles. After you've completed this configuration you can optionally choose to 
enable LDAPS to make LDAP traffic confidential and secure.
 
-## Enable LDAP in Druid
+## Prerequisites
 
-Before starting, verify that the active directory is reachable from the Druid 
Master servers. Command line tools such as `ldapsearch` and `ldapwhoami`, which 
are included with OpenLDAP, are useful for this testing. 
+Before you start to configure LDAP for Druid, test your LDAP connection and 
perform a sample search.
 
-### Check the connection
+### Check your LDAP connection
 
-First test that the basic connection and user credential works. For example, 
given a user `[email protected]`, try:
+Verify that your LDAP connection is working by testing it with user 
credentials. Later in the process you [configure Druid for LDAP 
authentication](#configure-druid-for-ldap-authentication) with this user as the 
`bindUser`.
+
+The following example command tests the connection for the user 
`[email protected]`. Insert your LDAP server IP address. Modify the port 
number of your LDAP instance if it listens on a port other than `389`.
 
 ```bash
-ldapwhoami -vv -H ldap://<ip_address>:389  -D"[email protected]" -W
+ldapwhoami -vv -H ldap://ip_address:389  -D "[email protected]" -W
 ```
 
-Enter the password associated with the user when prompted and verify that the 
command succeeded. If it didn't, try the following troubleshooting steps:  
+Enter the password for the user when prompted and verify that the command 
succeeded. If it failed, check the following:
+
+- Make sure you're using the correct port for your LDAP instance.
+- Check whether a network firewall is preventing connections to the LDAP port.
+- Review your LDAP implementation details to see whether you need to 
specifically whitelist LDAP clients at the LDAP server. If so, add the Druid 
Coordinator server to the whitelist.

Review Comment:
   ```suggestion
   - Review your LDAP implementation details to see whether you need to 
specifically allow LDAP clients at the LDAP server. If so, add the Druid 
Coordinator server to the allow list.
   ```
   avoid "whitelist", "blacklist"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to