abhishekagarwal87 commented on code in PR #13348:
URL: https://github.com/apache/druid/pull/13348#discussion_r1026625657


##########
docs/development/experimental-features.md:
##########
@@ -0,0 +1,72 @@
+---
+id: experimental-features
+title: "Experimental features"
+---
+
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one
+  ~ or more contributor license agreements.  See the NOTICE file
+  ~ distributed with this work for additional information
+  ~ regarding copyright ownership.  The ASF licenses this file
+  ~ to you under the Apache License, Version 2.0 (the
+  ~ "License"); you may not use this file except in compliance
+  ~ with the License.  You may obtain a copy of the License at
+  ~
+  ~   http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing,
+  ~ software distributed under the License is distributed on an
+  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  ~ KIND, either express or implied.  See the License for the
+  ~ specific language governing permissions and limitations
+  ~ under the License.
+  -->
+
+The following features are marked [experimental](./experimental.md) in the 
Druid docs.
+
+This document includes each page that mentions an experimental feature. To 
graduate a feature, remove all mentions of its experimental status on all 
relevant pages.
+
+## SQL-based ingestion
+
+- [SQL-based ingestion](../multi-stage-query/index.md)
+- [SQL-based ingestion concepts](../multi-stage-query/concepts.md)
+- [SQL-based ingestion and multi-stage query task 
API](../multi-stage-query/api.md)
+
+## Nested columns
+
+- [Nested columns](../querying/nested-columns.md)
+
+## Indexer process
+
+- [Indexer process](../design/indexer.md)
+- [Configuration reference](../configuration/index.md)
+- [Processes and servers](../design/processes.md)

Review Comment:
   How do these two links help here? They are not specific to the indexer 
process. 



##########
docs/development/experimental-features.md:
##########
@@ -0,0 +1,72 @@
+---
+id: experimental-features
+title: "Experimental features"
+---
+
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one
+  ~ or more contributor license agreements.  See the NOTICE file
+  ~ distributed with this work for additional information
+  ~ regarding copyright ownership.  The ASF licenses this file
+  ~ to you under the Apache License, Version 2.0 (the
+  ~ "License"); you may not use this file except in compliance
+  ~ with the License.  You may obtain a copy of the License at
+  ~
+  ~   http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing,
+  ~ software distributed under the License is distributed on an
+  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  ~ KIND, either express or implied.  See the License for the
+  ~ specific language governing permissions and limitations
+  ~ under the License.
+  -->
+
+The following features are marked [experimental](./experimental.md) in the 
Druid docs.
+
+This document includes each page that mentions an experimental feature. To 
graduate a feature, remove all mentions of its experimental status on all 
relevant pages.
+
+## SQL-based ingestion
+
+- [SQL-based ingestion](../multi-stage-query/index.md)
+- [SQL-based ingestion concepts](../multi-stage-query/concepts.md)
+- [SQL-based ingestion and multi-stage query task 
API](../multi-stage-query/api.md)
+
+## Nested columns
+
+- [Nested columns](../querying/nested-columns.md)
+
+## Indexer process
+
+- [Indexer process](../design/indexer.md)
+- [Configuration reference](../configuration/index.md)
+- [Processes and servers](../design/processes.md)
+
+## Kubernetes
+
+- [Kubernetes](../development/extensions-core/kubernetes.md)

Review Comment:
   not related to this PR but there is no way to land on `kubernetes` page 
using the navigation bar. something that should be fixed. 



##########
docs/development/experimental-features.md:
##########
@@ -0,0 +1,72 @@
+---
+id: experimental-features
+title: "Experimental features"
+---
+
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one
+  ~ or more contributor license agreements.  See the NOTICE file
+  ~ distributed with this work for additional information
+  ~ regarding copyright ownership.  The ASF licenses this file
+  ~ to you under the Apache License, Version 2.0 (the
+  ~ "License"); you may not use this file except in compliance
+  ~ with the License.  You may obtain a copy of the License at
+  ~
+  ~   http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing,
+  ~ software distributed under the License is distributed on an
+  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  ~ KIND, either express or implied.  See the License for the
+  ~ specific language governing permissions and limitations
+  ~ under the License.
+  -->
+
+The following features are marked [experimental](./experimental.md) in the 
Druid docs.
+
+This document includes each page that mentions an experimental feature. To 
graduate a feature, remove all mentions of its experimental status on all 
relevant pages.
+
+## SQL-based ingestion
+
+- [SQL-based ingestion](../multi-stage-query/index.md)
+- [SQL-based ingestion concepts](../multi-stage-query/concepts.md)
+- [SQL-based ingestion and multi-stage query task 
API](../multi-stage-query/api.md)
+
+## Nested columns
+
+- [Nested columns](../querying/nested-columns.md)
+
+## Indexer process
+
+- [Indexer process](../design/indexer.md)
+- [Configuration reference](../configuration/index.md)
+- [Processes and servers](../design/processes.md)
+
+## Kubernetes
+
+- [Kubernetes](../development/extensions-core/kubernetes.md)
+
+## Segment locking
+
+- [Configuration reference](../configuration/index.md)
+- [Task reference](../ingestion/tasks.md)

Review Comment:
   ```suggestion
   - [Task reference](../ingestion/tasks.md#locking)
   ```



##########
docs/development/experimental-features.md:
##########
@@ -0,0 +1,72 @@
+---
+id: experimental-features
+title: "Experimental features"
+---
+
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one
+  ~ or more contributor license agreements.  See the NOTICE file
+  ~ distributed with this work for additional information
+  ~ regarding copyright ownership.  The ASF licenses this file
+  ~ to you under the Apache License, Version 2.0 (the
+  ~ "License"); you may not use this file except in compliance
+  ~ with the License.  You may obtain a copy of the License at
+  ~
+  ~   http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing,
+  ~ software distributed under the License is distributed on an
+  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  ~ KIND, either express or implied.  See the License for the
+  ~ specific language governing permissions and limitations
+  ~ under the License.
+  -->
+
+The following features are marked [experimental](./experimental.md) in the 
Druid docs.
+
+This document includes each page that mentions an experimental feature. To 
graduate a feature, remove all mentions of its experimental status on all 
relevant pages.
+
+## SQL-based ingestion
+
+- [SQL-based ingestion](../multi-stage-query/index.md)
+- [SQL-based ingestion concepts](../multi-stage-query/concepts.md)
+- [SQL-based ingestion and multi-stage query task 
API](../multi-stage-query/api.md)
+
+## Nested columns
+
+- [Nested columns](../querying/nested-columns.md)
+
+## Indexer process
+
+- [Indexer process](../design/indexer.md)
+- [Configuration reference](../configuration/index.md)
+- [Processes and servers](../design/processes.md)
+
+## Kubernetes
+
+- [Kubernetes](../development/extensions-core/kubernetes.md)
+
+## Segment locking
+
+- [Configuration reference](../configuration/index.md)
+- [Task reference](../ingestion/tasks.md)
+- [Design](../design/architecture.md)

Review Comment:
   this and configuration reference page is not needed IMO. 



##########
docs/development/experimental-features.md:
##########
@@ -0,0 +1,72 @@
+---
+id: experimental-features
+title: "Experimental features"
+---
+
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one
+  ~ or more contributor license agreements.  See the NOTICE file
+  ~ distributed with this work for additional information
+  ~ regarding copyright ownership.  The ASF licenses this file
+  ~ to you under the Apache License, Version 2.0 (the
+  ~ "License"); you may not use this file except in compliance
+  ~ with the License.  You may obtain a copy of the License at
+  ~
+  ~   http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing,
+  ~ software distributed under the License is distributed on an
+  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  ~ KIND, either express or implied.  See the License for the
+  ~ specific language governing permissions and limitations
+  ~ under the License.
+  -->
+
+The following features are marked [experimental](./experimental.md) in the 
Druid docs.
+
+This document includes each page that mentions an experimental feature. To 
graduate a feature, remove all mentions of its experimental status on all 
relevant pages.
+
+## SQL-based ingestion
+
+- [SQL-based ingestion](../multi-stage-query/index.md)
+- [SQL-based ingestion concepts](../multi-stage-query/concepts.md)
+- [SQL-based ingestion and multi-stage query task 
API](../multi-stage-query/api.md)
+
+## Nested columns
+
+- [Nested columns](../querying/nested-columns.md)
+
+## Indexer process
+
+- [Indexer process](../design/indexer.md)
+- [Configuration reference](../configuration/index.md)
+- [Processes and servers](../design/processes.md)
+
+## Kubernetes
+
+- [Kubernetes](../development/extensions-core/kubernetes.md)
+
+## Segment locking
+
+- [Configuration reference](../configuration/index.md)
+- [Task reference](../ingestion/tasks.md)
+- [Design](../design/architecture.md)
+
+## Materialized view
+
+- [Materialized view](../development/extensions-contrib/materialized-view.md)

Review Comment:
   `contrib` extensions are not shipped as part of the release. They need not 
be documented. 



##########
docs/development/experimental-features.md:
##########
@@ -0,0 +1,72 @@
+---
+id: experimental-features
+title: "Experimental features"
+---
+
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one
+  ~ or more contributor license agreements.  See the NOTICE file
+  ~ distributed with this work for additional information
+  ~ regarding copyright ownership.  The ASF licenses this file
+  ~ to you under the Apache License, Version 2.0 (the
+  ~ "License"); you may not use this file except in compliance
+  ~ with the License.  You may obtain a copy of the License at
+  ~
+  ~   http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing,
+  ~ software distributed under the License is distributed on an
+  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  ~ KIND, either express or implied.  See the License for the
+  ~ specific language governing permissions and limitations
+  ~ under the License.
+  -->
+
+The following features are marked [experimental](./experimental.md) in the 
Druid docs.
+
+This document includes each page that mentions an experimental feature. To 
graduate a feature, remove all mentions of its experimental status on all 
relevant pages.
+
+## SQL-based ingestion
+
+- [SQL-based ingestion](../multi-stage-query/index.md)
+- [SQL-based ingestion concepts](../multi-stage-query/concepts.md)
+- [SQL-based ingestion and multi-stage query task 
API](../multi-stage-query/api.md)
+
+## Nested columns
+
+- [Nested columns](../querying/nested-columns.md)
+
+## Indexer process
+
+- [Indexer process](../design/indexer.md)
+- [Configuration reference](../configuration/index.md)
+- [Processes and servers](../design/processes.md)
+
+## Kubernetes
+
+- [Kubernetes](../development/extensions-core/kubernetes.md)
+
+## Segment locking
+
+- [Configuration reference](../configuration/index.md)
+- [Task reference](../ingestion/tasks.md)
+- [Design](../design/architecture.md)
+
+## Materialized view
+
+- [Materialized view](../development/extensions-contrib/materialized-view.md)
+
+## Moments sketch
+
+- [Aggregations](../querying/aggregations.md)
+
+## Front coding
+
+- [Ingestion spec reference](../ingestion/ingestion-spec.md#front-coding)
+
+## Other configuration properties
+
+- [Configuration reference](../configuration/index.md)
+   - Experimental task runner `httpRemote`

Review Comment:
   httpRemote is not considered experimental. I have seen it used in prod 
systems already. 



##########
docs/development/experimental-features.md:
##########
@@ -0,0 +1,72 @@
+---
+id: experimental-features
+title: "Experimental features"
+---
+
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one
+  ~ or more contributor license agreements.  See the NOTICE file
+  ~ distributed with this work for additional information
+  ~ regarding copyright ownership.  The ASF licenses this file
+  ~ to you under the Apache License, Version 2.0 (the
+  ~ "License"); you may not use this file except in compliance
+  ~ with the License.  You may obtain a copy of the License at
+  ~
+  ~   http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing,
+  ~ software distributed under the License is distributed on an
+  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  ~ KIND, either express or implied.  See the License for the
+  ~ specific language governing permissions and limitations
+  ~ under the License.
+  -->
+
+The following features are marked [experimental](./experimental.md) in the 
Druid docs.
+
+This document includes each page that mentions an experimental feature. To 
graduate a feature, remove all mentions of its experimental status on all 
relevant pages.
+
+## SQL-based ingestion
+
+- [SQL-based ingestion](../multi-stage-query/index.md)
+- [SQL-based ingestion concepts](../multi-stage-query/concepts.md)
+- [SQL-based ingestion and multi-stage query task 
API](../multi-stage-query/api.md)
+
+## Nested columns
+
+- [Nested columns](../querying/nested-columns.md)
+
+## Indexer process
+
+- [Indexer process](../design/indexer.md)
+- [Configuration reference](../configuration/index.md)
+- [Processes and servers](../design/processes.md)
+
+## Kubernetes
+
+- [Kubernetes](../development/extensions-core/kubernetes.md)
+
+## Segment locking
+
+- [Configuration reference](../configuration/index.md)
+- [Task reference](../ingestion/tasks.md)
+- [Design](../design/architecture.md)
+
+## Materialized view
+
+- [Materialized view](../development/extensions-contrib/materialized-view.md)
+
+## Moments sketch
+
+- [Aggregations](../querying/aggregations.md)

Review Comment:
   can you add link to the specific section of aggregations page? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to