gianm commented on code in PR #13354:
URL: https://github.com/apache/druid/pull/13354#discussion_r1027378268
##########
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisorTuningConfig.java:
##########
@@ -169,6 +174,23 @@ public Integer getWorkerThreads()
return workerThreads;
}
+ @Override
+ public boolean getChatAsync()
+ {
+ if (chatAsync != null) {
+ return chatAsync;
+ } else {
+ return DEFAULT_ASYNC;
+ }
+ }
+
+ @JsonProperty("chatAsync")
+ @JsonInclude(JsonInclude.Include.NON_NULL)
+ Boolean getChatAsyncConfigured()
Review Comment:
I did it this way because I didn't want `chatAsync` to appear in serialized
tuningConfigs unless it was actually set by the user. And, I wanted us to be
able to change the default in the future, and have everyone get the new default
if they hadn't explicitly set this. Let me know what you think of that
rationale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
