clintropolis opened a new pull request, #13405: URL: https://github.com/apache/druid/pull/13405
### Description Fixes an issue with nested column range index computation which was resulting in an off by 1 on the end index. #13297 almost fixed all of the issues, but as a showcase of how test line and branch coverage just tells you what you want to hear, the test cases were missing a scenario where the local end index was not missing and there were additional global values between the global id of the 'insertion point' of the missing value and the actual global end value. I've added data to the test which covers this case to the string dictionary (which caused a few additional tests to fail prior to the fixes in this PR), as well as additional test cases for range indexes to i think cover all of the scenarios.... i hope 😅 <hr> This PR has: - [x] been self-reviewed. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
