findingrish commented on code in PR #13365: URL: https://github.com/apache/druid/pull/13365#discussion_r1028946245
########## examples/bin/run-druid: ########## @@ -47,7 +47,35 @@ if [ ! -d "$LOG_DIR" ]; then mkdir -p $LOG_DIR; fi echo "Running [$1], logging to [$LOG_DIR/$1.log] if no changes made to log4j2.xml" +if [ "$WHATAMI" = 'coordinator-overlord' ] +then + SERVER_NAME=coordinator +else + SERVER_NAME="$WHATAMI" +fi + + +if [ ! -f "$CONFDIR"/$WHATAMI/main.config ]; + then + MAIN_CLASS="org.apache.druid.cli.Main server $SERVER_NAME" + else + MAIN_CLASS=`cat "$CONFDIR"/$WHATAMI/main.config | xargs` +fi + cd "$WHEREAMI/.." -exec "$WHEREAMI"/run-java -Ddruid.node.type=$1 "-Ddruid.log.path=$LOG_DIR" `cat "$CONFDIR"/"$WHATAMI"/jvm.config | xargs` \ - -cp "$CONFDIR"/"$WHATAMI":"$CONFDIR"/_common:"$CONFDIR"/_common/hadoop-xml:"$CONFDIR"/../_common:"$CONFDIR"/../_common/hadoop-xml:"$WHEREAMI/../lib/*" \ - `cat "$CONFDIR"/$WHATAMI/main.config | xargs` + +if [ "$#" -eq 3 ] +then + Review Comment: This is outdated, passing extra params for MM task properties to `run-druid` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
