imply-cheddar commented on PR #13258: URL: https://github.com/apache/druid/pull/13258#issuecomment-1328533122
Okay, I think I read the `.halt` javadoc wrong... So, yeah, ignore that previous comment. The real comment is this: what happens if we never get to the finally block? Like, if we block forever on that `lifecycle.stop()`. I forget the status of the threads when we ran into this, but I want to remember that it never even got to the `System.exit()` call. What if we skip the `lifecycle.stop` entirely and just halt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
