cryptoe commented on code in PR #13398:
URL: https://github.com/apache/druid/pull/13398#discussion_r1033169066


##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/test/MSQTestBase.java:
##########
@@ -462,6 +464,27 @@ protected File getResourceAsTemporaryFile(final String 
resource) throws IOExcept
     return file;
   }
 
+  /**
+   * Helper method that populates a temporary file with {@code numRows} rows 
and {@code numColumns} columns where the
+   * first column is a string 'timestamp' while the rest are string columns 
with junk value
+   */
+  protected File generateTemporaryNdJsonFile(final int numRows, final int 
numColumns) throws IOException

Review Comment:
   I think we can add a new class for this and the previous method. 
MSQTestFileUtils?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to