clintropolis commented on PR #13407:
URL: https://github.com/apache/druid/pull/13407#issuecomment-1329729823

   >Although due to the old behavior, would the sampler show empty map for null 
values in top level nested structures? But they'll be ingested as nulls.
   
   I think there was actually an issue with truly `null` valued rows, 
https://github.com/apache/druid/pull/13407/files#diff-5dbb6b823e8eebdd2f12a3d2da6e56d74c9d8cca55a168bc6eac6095ace46809L290
 would leak a `NullNode` at least for `JSON` inputs, which isn't an empty map 
at all so it would be a class cast exception. But yeah, the output of toMap for 
the sampler on one of these would effectively just be a row with all null 
values if it would have worked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to