vogievetsky commented on code in PR #13365: URL: https://github.com/apache/druid/pull/13365#discussion_r1035403056
########## examples/bin/start-druid: ########## @@ -0,0 +1,548 @@ +#!/usr/bin/env python3 + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import sys +import os +import psutil +import pathlib +import multiprocessing +import argparse + +QUICKSTART_ROOT_CONFIG_PATH = "conf/druid/single-server/quickstart" Review Comment: If I understand this correctly these configs will be used as a base and then they will be "extended" when the server starts using the info from the `--memory` config. If so I think we should not call these configs "quickstart". To me "quickstart" means the shitty cluster you spin up on your laptop just to check stuff out (vs the "real" cluster you will deploy later). If my understanding is correct I would call these "base" configs or something similar because you might actually go into production with your start script being `bin/start-druid -m 64g` or something light that. Also this is not really single server right? You might run `bin/start-druid -s broker,router` on once server and then `bin/start-druid -s historical,middleManager` and `bin/start-druid -s coordinator-overlord` on other servers to make a multi-server cluster. I would have the configs live in a new location like `conf/druid/base` or `conf/druid/dynamic` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
