rohangarg commented on code in PR #13368:
URL: https://github.com/apache/druid/pull/13368#discussion_r1035713413
##########
processing/src/main/java/org/apache/druid/frame/processor/SuperSorter.java:
##########
@@ -517,19 +504,26 @@ private boolean runNextMiddleMerger()
(pos == maxChannelsPerProcessor - 1 || (totalInputs !=
UNKNOWN_TOTAL && w == totalInputs - 1))) {
// We found a set to merge. Let's collect the input channels and
launch the merger.
final List<ReadableFrameChannel> in = new ArrayList<>();
+ final List<PartitionedReadableFrameChannel>
partitionedReadableFrameChannels = new ArrayList<>();
for (long i = currentSetStart; i < currentSetStart +
maxChannelsPerProcessor; i++) {
if (inputsReady.remove(i)) {
- try {
- final FrameFile handle =
FrameFile.open(mergerOutputFile(inLevel, i), FrameFile.Flag.DELETE_ON_CLOSE);
- in.add(new ReadableFileFrameChannel(handle));
- }
- catch (IOException e) {
- throw new RuntimeException(e);
- }
+ String levelAndRankKey = StringUtils.format("merged.%d.%d",
inLevel, i);
Review Comment:
done, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
