churromorales commented on PR #13370: URL: https://github.com/apache/druid/pull/13370#issuecomment-1332709448
@clintropolis i looked at the long encoding work some more and think it handles everything for us. If we take a look at `VSizeLongSerde.getSerializer()` it looks like it only stores the bits it needs. I think this PR is not necessary with this feature, but I do have a suggestion. I believe this patch has been in for a while and we should make long encoding on by default. When I tested the encoding vs unsigned int, it encoded better because it rarely stored leading 0's. What do you think about me closing this PR and having another one to have long encoding on by default in druid? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
