clintropolis commented on code in PR #13426:
URL: https://github.com/apache/druid/pull/13426#discussion_r1037505963
##########
core/src/main/java/org/apache/druid/guice/DruidSecondaryModule.java:
##########
@@ -36,6 +36,7 @@
import javax.validation.Validator;
import java.util.Properties;
+@LazySingleton
Review Comment:
was this needed by something?
##########
processing/src/main/java/org/apache/druid/jackson/DefaultObjectMapper.java:
##########
@@ -42,6 +42,8 @@
*/
public class DefaultObjectMapper extends ObjectMapper
{
+ public static final DefaultObjectMapper INSTANCE = new DefaultObjectMapper();
Review Comment:
this seems to be used in one place unless i'm missing others, when should it
be used?
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteIngestionDmlTest.java:
##########
@@ -299,13 +363,23 @@ private void verifySuccess()
.expectedResources(expectedResources)
.run();
+ String expectedLogicalPlan;
+ if (expectedLogicalPlanResource != null) {
+ expectedLogicalPlan = StringUtils.getResource(
+ this,
+ "/calcite/expected/ingest/" + expectedLogicalPlanResource +
"-logicalPlan.txt"
Review Comment:
is this a bit fragile since it requires naming files correctly? (i don't
really have any better ideas, just thinking out loud)
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/PlannerCaptureHook.java:
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.sql.calcite.planner;
+
+import org.apache.calcite.interpreter.BindableRel;
+import org.apache.calcite.rel.RelRoot;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.sql.SqlInsert;
+import org.apache.druid.sql.calcite.rel.DruidRel;
+
+public class PlannerCaptureHook implements PlannerHook
+{
+ // Uncomment the various fields, and add getter, when
+ // needed by tests. Code won't pass SpotBugs otherwise.
+ //private String sql;
Review Comment:
hmm, is there any reason to keep these around commented out? alternatively,
why not just `@SuppressWarnings` or something? Or maybe I'm missing some
context since this PR was split out of another PR...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
